search

neoclide / coc.nvim

Nodejs extension host for vim & neovim, load extensions like VSCode and host language servers.
Other
24.36k stars 956 forks source link

fix(inlayHint): hl_mode = 'replace' for neovim #4949

Closed kevinhwang91 closed 6 months ago

kevinhwang91 commented 6 months ago

Problem: https://github.com/neovim/neovim/issues/24152 The inlays are affected by the other highlight groups. Solution: use replace value for hl_mode instead of combine.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.57%. Comparing base (1a8244e) to head (2ad01b0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4949 +/- ## ======================================= Coverage 98.57% 98.57% ======================================= Files 273 273 Lines 26077 26077 Branches 5392 5392 ======================================= + Hits 25705 25706 +1 + Misses 219 217 -2 - Partials 153 154 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fannheyward commented 6 months ago

~From :h nvim_buf_set_extmark, the hl_mode's default value is replace, did I misunderstand it?~

coc.nvim uses combine as default value https://github.com/neoclide/coc.nvim/blob/1a8244e3fad3a098caaf2f0b1402faeb645e787a/autoload/coc/vtext.vim#L49