neoclide / coc.nvim

Nodejs extension host for vim & neovim, load extensions like VSCode and host language servers.
Other
24.15k stars 953 forks source link

fix(inlayHint): more compact padding highlight group #4950

Closed kevinhwang91 closed 3 months ago

kevinhwang91 commented 3 months ago

If the chunk is an array with a single string, the highlight group only uses the foreground of Normal, which makes cursorline look better.

Reference: https://github.com/neovim/neovim/blob/0f85aeb478a68c18a8195e69724e1cb618fec058/runtime/lua/vim/lsp/inlay_hint.lua#L333-L337

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.56%. Comparing base (b01ae44) to head (8ea23e8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4950 +/- ## ======================================= Coverage 98.56% 98.56% ======================================= Files 273 273 Lines 26060 26060 Branches 5386 5386 ======================================= Hits 25686 25686 Misses 220 220 Partials 154 154 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

qiqiboy commented 3 months ago

inlayhint in vim9 not work from this commit

fannheyward commented 3 months ago

inlayhint in vim9 not work from this commit

Reproduced

fannheyward commented 3 months ago

@qiqiboy made a quick fix, set hl_group for hint in Vim