search

neoclide / coc.nvim

Nodejs extension host for vim & neovim, load extensions like VSCode and host language servers.
Other
24.15k stars 953 forks source link

fix(extension): quote cmd on windows #4988

Closed fannheyward closed 2 months ago

fannheyward commented 2 months ago

Closes #4987

on windows, command should be quoted if containing spaces. https://github.com/nodejs/node/issues/7367

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.55%. Comparing base (77ae2d4) to head (7adc95a).

Files Patch % Lines
src/extension/installer.ts 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4988 +/- ## ======================================= Coverage 98.55% 98.55% ======================================= Files 273 273 Lines 26070 26071 +1 Branches 5389 5390 +1 ======================================= + Hits 25692 25694 +2 + Misses 222 220 -2 - Partials 156 157 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.