neoclide / coc.nvim

Nodejs extension host for vim & neovim, load extensions like VSCode and host language servers.
Other
24.15k stars 953 forks source link

fix(coc#has_item_selected) #5067

Closed Kaiser-Yang closed 6 days ago

Kaiser-Yang commented 6 days ago

I find that coc#pum#visible use getwinvar(s:pum_winid, 'float', 0) == 1 to check the window. So using s:pum_winid == -1 may cause problems, now use coc#pum#visible() to check if the pum is visible.

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.51%. Comparing base (b37b3e0) to head (5c123c6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5067 +/- ## ======================================= Coverage 98.51% 98.51% ======================================= Files 273 273 Lines 26084 26084 Branches 5390 5390 ======================================= Hits 25697 25697 Misses 227 227 Partials 160 160 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.