search

neocotic / europa

Library for converting HTML into valid Markdown
MIT License
159 stars 24 forks source link

Trim only end #41

Closed eleith closed 7 years ago

eleith commented 11 years ago

if i try and convert a single line that is a code block, the indent at the beginning will get trimmed

so something like

<pre><code>this is a code block</code></pre>

gets turned into 

this is a code block

but i actually want

    this is a code block

it will work if you have lines before it, just not if you have one line.

tests included.

neocotic commented 7 years ago

Sorry for taking so so very long to address this. I finally got around to doing the massive rewrite of this library that I wanted to. It's been renamed Europa and it's totally changed.

Unfortunately, this issue still exists in Europa. While I completely rewrote the code from scratch, the same logic exists for each tag.

As part of the rewrite I split the the project into multiple modules to simplify everything. This means that all logic now exists within europa-core.

Now I don't know if you still use html-md or if you'd want to see this change make it into Europa, but if you do, can you please open a similar PR against europa-core? I'd love to see this fix make it in. I'm trying to pay more attention to my more popular projects but each of them have required big rewrites to make them more maintainable, which was always off-putting and a little bit scary.

I'm closing this PR now as it's no longer valid for this repo. If you still use html-md, please give europa a shot and let me know how you get on.

Sorry again for the massive delay.