search

neocotic / qrious

Pure JavaScript library for QR code generation using canvas
https://neocotic.com/qrious
Other
1.55k stars 215 forks source link

Update node-canvas version #38

Closed throrin19 closed 9 years ago

throrin19 commented 9 years ago

Update node-canvas version to 1.2.9 to get the compatibility with NodeJS 4.0.0

neocotic commented 9 years ago

Have you checked that qr.js still works correctly with canvas v1.2.9 and above on older versions of Node.js (e.g. 0.10, 0.12)?

throrin19 commented 9 years ago

Node canvas 1.2.9 works fine with nodeJS >=0.8.0. It works fine with nodejs 0.12. I don't test with NodeJS 0.10 (and I can't)

neocotic commented 9 years ago

Thanks for checking. I'll take a look at this tomorrow night (next time I'm - hopefully - free).

neocotic commented 9 years ago

@throrin19 I've merged your fix and it's been included in v1.1.4 which I've just published. Thanks for all your help!