neodix42 / ton4j

Java libraries for interacting with TON blockchain.
GNU General Public License v3.0
28 stars 10 forks source link

Refactor/anti melman #4

Closed sidohin-felix closed 1 month ago

neodix42 commented 4 months ago

You can't just come to ton4j and then burger king.

You started to do the changes based on a very old version of ton4j (0.0.2) ~ 1.5y old. Since that time, I have also implemented a lot of changes, like TL-B support, HashMapAug and etc. It would be way better if you push smaller PRs, but more frequently. I don't like gradle, so don't try to replace maven. There is no point to remove smartcontract module it contains valuable smc interfaces. Class typing (TypedAsyncObject) is just another flavor and your way of doing it. Tonlib is already thread-safe. I took a few methods from your PR created by Vitaly Valtman.

I can't merge your PR with so many changes. I recommend you to keep your own version of ton4j and merge changes from official ton4j whenever you need them.