neoforged / Documentation

The repository containing Neo's documentation
MIT License
28 stars 53 forks source link

Fix Advancements page #173

Closed TathanDev closed 1 month ago

TathanDev commented 1 month ago

This PR fix two things in the advancements page.

Supplier#value()

In the docs, there is written that for the performExampleAction, we need to use get our registry but with the non-existent value() method and it should be replaced with the get() method.

Parameter name for AdvancementGenerator

This is a minor change. To datagen an advancement, we need to create a class that implements AdvancementProvider.AdvancementGenerator. This interface have the generate method with theses paramaters HolderLookup.Provider registries, Consumer<AdvancementHolder> saver, ExistingFileHelper existingFileHelper but in the docs, the parameter consumer is named saver

AdvancementRewards.Builder#addLootTable() require a ResourceKey

In the docs, to add a lootTable, it says that the function AdvancementRewards.Builder#addLootTable() require a ResourceLocation but it actually need a ResourceKey<LootTable>