neoforged / Documentation

The repository containing Neo's documentation
MIT License
28 stars 49 forks source link

Inaccuracy in screen.md #26

Closed tmvkrpxl0 closed 5 months ago

tmvkrpxl0 commented 11 months ago

In sub-section Textuers, it says this:

Textures are drawn through blitting, hence the method name #blit, which, for this purpose, copies the bits of an image and draws them directly to the screen. These are drawn through a position texture shader. While there are many different #blit overloads, we will only discuss two static #blits. The first static #blit takes in six integers and assumes the texture being rendered is on a 256 x 256 PNG file. It takes in the left x and top y screen coordinate, the left x and top y coordinate within the PNG, and the width and height of the image to render.

There isn't static method in GuiScreen. and method it refers to seems to have this signature now: public void blit(ResourceLocation pAtlasLocation, int pX, int pY, int pUOffset, int pVOffset, int pUWidth, int pVHeight) Because it is the only method with 256 constant

ChampionAsh5357 commented 11 months ago

Pretty sure that was a 20.1-20.2 change iirc.

tmvkrpxl0 commented 11 months ago

Also https://github.com/neoforged/Documentation/blob/main/docs/gui/screens.md?plain=1#L19C202-L19C202

These fall into five categories: colored rectangles, strings, and textures, items, and tooltips.

It has 2 ands