neoforged / Documentation

The repository containing Neo's documentation

MIT License

23 stars 36 forks source link

Update docs for capability rework #34

Closed Technici4n closed 6 months ago

Technici4n commented 6 months ago

Mostly adapted from the blog post, but keeping some of the old content where that made sense.

Beyond the two main changed files, I also fixed references to capabilities elsewhere. Some of the other pages will still need an update, but at least everything related to caps should be clean now.

Preview URL: https://pr-34.neoforged-docs-previews.pages.dev

neoforged-pages-deployments[bot] commented 6 months ago

Deploying with Cloudflare Pages

Name	Result
Last commit:	714a87f7ff02164c11d0b62d1c574f9d7b8b52f5
Status:	✅ Deploy successful!
Preview URL:	https://c7514fe0.neoforged-docs-previews.pages.dev
PR Preview URL:	https://pr-34.neoforged-docs-previews.pages.dev

XFactHD commented 6 months ago

Looks good to me overall, just a few minor points

It might be worth mentioning that the fluid capability for items is slightly special due to the way buckets hold fluids
The remark regarding why block caps are looked up from the level now should explicitly mention why (i.e. that blocks without BEs can have caps now as well)
If the holder of a data attachment requires it, is it automatically marked dirty when a non-existent attachment is retrieved and therefore default-initialized?

Other than that: :shipit: