search

neoforged / MDK

The Mod Developer Kit - this is where you start if you want to develop a new mod
https://github.com/NeoForgeMDKs
183 stars 60 forks source link

Make the MDK automatically update to the latest NeoGradle #30

Closed Spinoscythe closed 6 months ago

TelepathicGrunt commented 6 months ago

I am not sure this is a good idea. If NeoGradle releases a breaking change, the MDK would be broken until someone makes a PR to fix it. It also means any mod using the MDK as a base will suddenly break one day and people won't know why. Updating NeoGradle should be a explicit action that the modder takes so they know if they are experiencing a breaking change or not

TelepathicGrunt commented 6 months ago

Unless of course, NeoGradle breaking changes are codified into the minor version number. Then 7.0.+ would be a better idea instead of 7.+

Spinoscythe commented 6 months ago

Both achieve the same thing, so it isn't a big issue.

Matyrobbrt commented 6 months ago

Due to the way the build and configuration cache behaves, any update to plugins will also cause an entire decomp/recomp cycle. So this will make people run that setup all over again for seemingly random reasons. Not to mention that reproducibility is also broken by the use of ranges in plugin versions, which gradle discourages. NG is rather stable right now and updates aren't that frequent. If people run into issues they can ask, and if it's fixed already we will tell them to update.