search

neoforged / MDK

The Mod Developer Kit - this is where you start if you want to develop a new mod
https://github.com/NeoForgeMDKs
183 stars 60 forks source link

Bugs #54

Closed lZiMUl closed 2 months ago

lZiMUl commented 2 months ago

In this file /src/main/resources/META-INF/neoforge.mods.toml There are some bugs

The IDE error is due to this [[dependencies.${mod_id}]] It should be [[dependencies."${mod_id}"]]

Includes 69 lines, 88 lines, 99 lines

Spinoscythe commented 2 months ago

that shouldn't cause issues. it just says an issue cause it has to. this shouldn't cause an error in the runtime

lZiMUl commented 2 months ago

这应该不会引起问题。它只是说一个问题，因为它必须这样做。这不应导致运行时出错

image

Are you sure that's okay?

TelepathicGrunt commented 2 months ago

If you build the jar file and open it up, does the neoforge.mods.toml file there have the value replaced properly?

lZiMUl commented 2 months ago

如果您构建 jar 文件并打开它，那里的 neoforge.mods.toml 文件是否正确替换了值？

I haven't compiled and tested it yet Because most of my mods are no longer working At the moment I don't know what to do I went to the official documentation and didn't give a specific method for the time being

lol :)

Shadows-of-Fire commented 2 months ago

We use gradle's processResources task to do template expansion in the neoforge.mods.toml file so you don't have to duplicate data between gradle.properties and neoforge.mods.toml. This means that before the template expansion, the syntax is invalid, but it will be corrected at build time.

You can see the part of the build.gradle responsible for the expansion here.