search

neoforged / ModDevGradle

A Gradle plugin for developing Minecraft mods using NeoForge
https://projects.neoforged.net/neoforged/moddevgradle
GNU Lesser General Public License v2.1
38 stars 5 forks source link

Update to files in maven local might not invalidate the cache #140

Closed Technici4n closed 2 months ago

Technici4n commented 2 months ago

My analysis is as follows:

If only the contents of some file from maven local changed, Gradle will rerun createArtifactManifest, but its output won't change (because it only stores the file paths), meaning that createMinecraftArtifacts will not re-run.

I suppose this is only relevant for a few artifacts, for example NeoForge's.

lukebemish commented 2 months ago

One solution to this is to feed the same stuff in as a file collection input into createMinecraftArtifacts as is fed in as metadata/artifact inputs into createArtifactManifest, so that its content is considered an input for the former task.

neoforged-releases[bot] commented 2 months ago

🚀 This issue has been resolved in ModDevGradle version 2.0.24-beta, as part of #149.