search

neoforged / ModDevGradle

A Gradle plugin for developing Minecraft mods using NeoForge
https://projects.neoforged.net/neoforged/moddevgradle
GNU Lesser General Public License v2.1
25 stars 6 forks source link

Jar-in-Jar: Throw when only incompatible version ranges were specified #30

Closed shartte closed 1 month ago

shartte commented 2 months ago

For example, Gradle allows [1.0,2.0[, but Maven insists on [1.0,2.0).

neoforged-pr-publishing[bot] commented 2 months ago

Last commit published: 7a93e007d9298c5bc7bdc22c611ff10f28121d02.

PR Publishing ### The artifacts published by this PR: - :package: [`net.neoforged.moddev.repositories:net.neoforged.moddev.repositories.gradle.plugin:0.1.99-pr-30-validate-version-ranges`](https://github.com/neoforged/ModDevGradle/packages/2179882) - :package: [`net.neoforged.moddev:net.neoforged.moddev.gradle.plugin:0.1.99-pr-30-validate-version-ranges`](https://github.com/neoforged/ModDevGradle/packages/2179880) - :package: [`net.neoforged:moddev-gradle:0.1.99-pr-30-validate-version-ranges`](https://github.com/neoforged/ModDevGradle/packages/2179879) ### Repository Declaration In order to use the artifacts published by the PR, add the following repository to your buildscript: ```gradle repositories { maven { name 'Maven for PR #30' // https://github.com/neoforged/ModDevGradle/pull/30 url 'https://prmaven.neoforged.net/ModDevGradle/pr30' content { includeModule('net.neoforged.moddev.repositories', 'net.neoforged.moddev.repositories.gradle.plugin') includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin') includeModule('net.neoforged', 'moddev-gradle') } } } ```
shartte commented 2 months ago

Shouldn't we throw if any version range is invalid?

IDK, it would certainly make the coder easier...