search

neoforged / NeoForge

Neo Modding API for Minecraft, based on Forge
https://projects.neoforged.net/neoforged/neoforge
Other
1.04k stars 134 forks source link

`MapDecoration.java.patch` Add the patch, or remove it #1075

Open Lolothepro opened 4 weeks ago

Lolothepro commented 4 weeks ago

https://github.com/neoforged/NeoForge/blob/1.20.x/patches/net/minecraft/world/level/saveddata/maps/MapDecoration.java.patch

https://github.com/neoforged/NeoForge/blob/ef52a013d85b1b713904f80c121bf061e9596079/patches/net/minecraft/world/level/saveddata/maps/MapDecoration.java.patch#L7

https://github.com/neoforged/NeoForge/blob/ef52a013d85b1b713904f80c121bf061e9596079/patches/net/minecraft/world/level/saveddata/maps/MapDecoration.java.patch#L8

This patch seems to be useless, is it possible to check why the file still exists?

Minecraftschurli commented 3 weeks ago

Why is it not needed? shouldRenderForIndex got removed and replaced by a comment stating to reevaluate it.