neoforged / NeoForge

Neo Modding API for Minecraft, based on Forge
https://projects.neoforged.net/neoforged/neoforge
Other
1.17k stars 172 forks source link

A light level of “1” is not rendered with NeoForge's experimental pipeline. #1093

Open Lolothepro opened 3 months ago

Lolothepro commented 3 months ago

Minecraft Version: 1.20.1/1.21

NeoForge Version: For example : NeoForge 21.0.0-alpha.rc-1, but also affects Minecraft 1.20.1

Steps to Reproduce:

  1. Set experimentalForgeLightPipelineEnabled to true
  2. Go into a cave
  3. Use the "/give Lolothepro29 light" command
  4. Place the light in a dark area
  5. Right-click to set light to 0
  6. Take a screenshot
  7. Right-click to set light to 1
  8. Take a screenshot
  9. Compare the light level, and note that there is no change

Description of issue: A light level of “1” is not rendered with NeoForge's experimental pipeline.

Screenshot:

0: 2024-06-11_16 33 19

1: 2024-06-11_16 33 30

With Sodium:

0: 2024-06-11_16 35 20

1: With Sodium: 2024-06-11_16 35 26

XFactHD commented 3 months ago

Sodium is not a valid point of comparison. Please provide a comparison with vanilla.

Lolothepro commented 3 months ago

Sodium is not a valid point of comparison. Please provide a comparison with vanilla.

But with Minecraft Vanilla, light propagation doesn't work correctly (MC-197497)

Lolothepro commented 3 months ago

for example:

2024-06-13_14 37 04

TelepathicGrunt commented 3 months ago

That’s fine. We still want to match vanilla or be as close as we reasonably can to vanilla. We are not going to match another mod’s behavior because modloaders aren’t designed around a single specific mod.