neoforged / NeoForge

Neo Modding API for Minecraft, based on Forge
https://projects.neoforged.net/neoforged/neoforge
Other
1.1k stars 161 forks source link

Mod descriptions are sometimes weirdly cut off in the mods menu. #1280

Open KiriCattus opened 1 month ago

KiriCattus commented 1 month ago

Minecraft Version: 1.21

NeoForge Version: 21.0.81

Logs: N/A

Steps to Reproduce: / Description of issue: Set up any test mod or existing workspace with a valid mods screen configuration and fill it with text like shown in the example here image

Notice that some of the text is cut off at the bottom of the mod description, now if I try to scroll down I can't but if I scroll up it cuts more of the text off like so without any scroll bar existing (without any need to scroll up either) image

This issue only seems to show up when launching Minecraft using the default window resolution that vanilla ships with as when the window is shrunk text shrinks down in size and when extended everything fits.

This issue also seems to persist when you have enough text to need a scroll bar again with default window resolution image

Extra details: No extra mods/dependencies are required, those are just what I had in the workspace by default in my set up. If any changes are needed, you have any questions or if I have made a mistake you'd like me to correct just give me a poke :)

TelepathicGrunt commented 1 month ago

I can't seem to reproduce the issue. I tried various screen sizes. Description lengths, etc. image

Are you using latest Neo? What is the exact dimension of the window if you know? The DPI of your monitor? And got a copy of your description text on hand? Trying to get as much info for reproducing. My Laptop's monitor might have too high resolution to reproduce issue

KiriCattus commented 1 month ago

When I reported the issue I was on the latest build however I was about 40 builds behind when I initially found the issue (I updated before I reported it though to make sure it wasn't already fixed) Screen size: 27" Screen resolution: 2560x1440 Windows weird scale system: 100% DPI: 109 Minecraft window size: 854x480 (Default size as far as I'm aware) Repository that has the same issue: repo commit ID: 2770024 (It says it failed to build but it works fine locally, I suspect a maven time out is the issue Build works fine now, was a maven issue)

UpcraftLP commented 1 week ago

image

Can confirm it happens for me too Screen is 27" 2560x1440

PlatinPython commented 1 week ago

With the linked repo, I also encounter this issue. I was not able to reproduce it on my own mod with just adding more text to the description tho. 32", 2560x1440

KiriCattus commented 1 week ago

Update: I took the default NeoForge MDK (the MDG one), updated it to 1.21.1 and tweaked the neoforge.mods.toml/gradle.properties files to mimic this set up, ALL of the links, credits, images and so on need to be enabled, and I can paste the exact description too.

Image without scrolling or resizing the window: image

Image when I attempt to scroll without resizing the window: image

Text used for description (Though this is not an exact requirement, just something roughly the same size) aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa I cant stop screaming and I dont know why anymore!!!! Please send help before I loose my

An extra note, if you leave the mods screen and return, click on either Minecraft or NeoForge, look at the top above the NeoForge logo and try to scroll, it moves a little when it has no need to/shouldn't, most likely a different issue but related

Without scrolling: image

Once scrolled: image