neoforged / NeoForge

Neo Modding API for Minecraft, based on Forge
https://projects.neoforged.net/neoforged/neoforge
Other
1.1k stars 161 forks source link

Remove baby zombie config options in future MC version (1.21?) #134

Closed TelepathicGrunt closed 9 months ago

TelepathicGrunt commented 11 months ago

I came across this in the server config file for Neoforge which was in inherited from Forge. image

In my opinion, this is not the domain of a modloader API. Rather this zombie villager baby chance should be handled by a separate mod made by someone else that Neoforge loads just like any other mod when in mod folder. There's no reason for this config option to be in Neoforge itself.

Thoughts?

Code: https://github.com/neoforged/NeoForge/blob/0974ecc143f449087139a6923aa3f0823dce421d/src/main/java/net/minecraftforge/common/ForgeConfig.java#L26-L27

TheCurle commented 11 months ago

I concur. This seems within the purview of a mod like In Control! as opposed to the modloader.

Shadows-of-Fire commented 11 months ago

Yeah I have no idea why these were controls in the first place, they're extremely old. They can be nuked next BC window.

heipiao233 commented 11 months ago

And in my opinion, mod loaders should not fix vanilla bugs.

AterAnimAvis commented 11 months ago

It depends on the bug, some Vanilla bugs can adversely effect modding environments quite drastically. Fixing these at the Loader level makes sense. However that isn't relevant in this case as this isn't a bug fix, this is an additional feature which falls in a category really outside our purview.

heipiao233 commented 11 months ago

just btw

TelepathicGrunt commented 11 months ago

Also, this config isn’t even fixing any bugs. They are just… there… for no reason that I can see lol