neoforged / NeoForge

Neo Modding API for Minecraft, based on Forge
https://projects.neoforged.net/neoforged/neoforge
Other
1.15k stars 166 forks source link

[1.21.1] Missing Crying Obsidian form the `c:obsidians` tag group? #1535

Closed ffuentesm closed 4 days ago

ffuentesm commented 1 week ago

I just want to confirm if the lack of the c:obsidians on the crying obsidian block was on purpose or not. Because the tag itself being "obsidians" in plural, means that there is more than one of them in that tag group.

image image

TelepathicGrunt commented 1 week ago

The obsidians tag is old. Really old. It was never updated to have crying obsidian back in forge when it was forge:obsidian

So just means we need to update the tag to account for the newer block.

tmvkrpxl0 commented 1 week ago

Btw what's the use case of the tag? I've never seen mods that add new type of obsidian

ffuentesm commented 1 week ago

Irons Spellbook uses it for a crafting item.

But in reality, it would just make both obsidian blocks interchangeable in crafting. I wonder if that would make any use in custom portal frame materials, so to allow crying obsidian in the portal activation.

HenryLoenwind commented 1 week ago

I've never seen mods that add new type of obsidian

I have. Coloured Obsidian was a thing.

TelepathicGrunt commented 1 week ago

There was that Nether Reactor in Pocket Edition that would spawn some weird glowing red Obsidian thing called Glowing Obsidian. Any mod porting that to Java must add that block lol. So technically Minecraft history had 3 different obsidian types

image

neoforged-releases[bot] commented 4 days ago

🚀 This issue has been resolved in NeoForge version 21.1.52, as part of #1536.