search

neoforged / NeoForge

Neo Modding API for Minecraft, based on Forge
https://projects.neoforged.net/neoforged/neoforge
Other
1.1k stars 161 forks source link

| gfx: *Fabulous!* | Falling blocks are not rendered when they are a translucent block. #154

Closed Lolothepro closed 9 months ago

Lolothepro commented 10 months ago

Vanilla: image

Forge: image

I found the reason... It has to do with how Fabulous! mode works combined with Forge allowing fancy stuff with render types of baked models: https://github.com/neoforged/NeoForge/blob/1.20.x/patches/minecraft/net/minecraft/client/renderer/entity/FallingBlockRenderer.java.patch#L10. In short, that patch is missing a "render type conversion" so to speak. I'll make a PR when 1.20.2 is ready

@XFactHD via Discord

Lolothepro commented 9 months ago

fixed in 1.20.2

XFactHD commented 9 months ago

The fix is unfortunately not quite correct. I'll PR the proper fix I had in mind in a bit