neoforged / NeoForge

Neo Modding API for Minecraft, based on Forge
https://neoforged.net
Other
1.25k stars 179 forks source link

[1.21.3] Sync remaining `c` tags from Fabric side #1628

Open TelepathicGrunt opened 1 month ago

TelepathicGrunt commented 1 month ago

1.21.3 port of https://github.com/neoforged/NeoForge/pull/1593

Note, I did not add any new Pale Garden stuff myself to the tags because those will need special handling to only add to the tags when the user activates the feature flag. Maybe that is better split into a separate PR by someone with more experience with feature flags than me.


Fabric had some tags that was not in Neo. This PR aims to solve that by importing those tags. Specifically c:potions item tag and c:is_temperate biome tags. I added the torchflower seeds to c:seeds/torchflower and then added that to the c:seeds tag as well as it was a missing seed.

I also improved javadoc for several tags, did some cleanup in a few spots, and marked the c:is_modified biome tag as deprecated and for removal in 1.22. Reason being the modified tag was based off of how the old biome layout used to work in the long past. Since Mojang revamped how biomes work, this tag lost all of its meaning and serves no purpose anymore. Hence time to retire it.

The PR to add the tags that are not in Fabric from Neoforge is in this other PR. Discussions ongoing of course: https://github.com/FabricMC/fabric/pull/4161

neoforged-pr-publishing[bot] commented 1 month ago

Last commit published: 2d3ec4b0e8674b418f07f31e1870881d04c17044.

PR Publishing ### The artifacts published by this PR: - :package: [`net.neoforged:testframework:21.3.23-beta-pr-1628-SyncToFabricTags2`](https://github.com/neoforged/NeoForge/packages/2294309) - :package: [`net.neoforged:neoforge:21.3.23-beta-pr-1628-SyncToFabricTags2`](https://github.com/neoforged/NeoForge/packages/2294307) ### Repository Declaration In order to use the artifacts published by the PR, add the following repository to your buildscript: ```gradle repositories { maven { name 'Maven for PR #1628' // https://github.com/neoforged/NeoForge/pull/1628 url 'https://prmaven.neoforged.net/NeoForge/pr1628' content { includeModule('net.neoforged', 'testframework') includeModule('net.neoforged', 'neoforge') } } } ``` ### MDK installation In order to setup a MDK using the latest PR version, run the following commands in a terminal. The script works on both *nix and Windows as long as you have the JDK `bin` folder on the path. The script will clone the MDK in a folder named `NeoForge-pr1628`. On Powershell you will need to remove the `-L` flag from the `curl` invocation. ```sh mkdir NeoForge-pr1628 cd NeoForge-pr1628 curl -L https://prmaven.neoforged.net/NeoForge/pr1628/net/neoforged/neoforge/21.3.23-beta-pr-1628-SyncToFabricTags2/mdk-pr1628.zip -o mdk.zip jar xf mdk.zip rm mdk.zip || del mdk.zip ``` To test a production environment, you can download the installer from [here](https://prmaven.neoforged.net/NeoForge/pr1628/net.neoforged/neoforge/21.3.23-beta-pr-1628-SyncToFabricTags2/neoforge-21.3.23-beta-pr-1628-SyncToFabricTags2-installer.jar).