search

neoforged / NeoForge

Neo Modding API for Minecraft, based on Forge
https://neoforged.net
Other
1.25k stars 179 forks source link

[1.21.3] Fix `ToolMaterial` and `ArmorMaterial` causing crashes when unique tags are used #1651

Closed dhyces closed 3 weeks ago

dhyces commented 3 weeks ago

Closes #1631

The fix for this issue was to call MappedRegistry#bindAllTagsToEmpty before refreezing registries. Vanilla calls this when they freeze registries, allowing them to use named HolderSets in registry objects before they're available in-game (such as in ToolMaterials and ArmorMaterials). If this is not called, then tags are left unbound and freeze throws an exception. Vanilla's tags remained bound when NeoForge unfroze registries, however any new tags used were not bound on refreeze.

neoforged-pr-publishing[bot] commented 3 weeks ago
neoforged-releases[bot] commented 3 weeks ago

🚀 This PR has been released as NeoForge version 21.3.7-beta.