search

neoforged / NeoForge

Neo Modding API for Minecraft, based on Forge
https://projects.neoforged.net/neoforged/neoforge
Other
1.13k stars 165 forks source link

Minecraft Demo overlay is not rendered with NeoForge #166

Closed Lolothepro closed 9 months ago

Lolothepro commented 11 months ago

Vanilla: 2023-10-04_18 38 06

Neo: 2023-10-04_18 36 31

(time remaining in left/right corner)

KnightMiner commented 11 months ago

Is this a bug though? The vanilla one looks barely readable due to the overlap, so looks like a Forge fix. I assume when the debug screen is disabled the two look the same.

Lolothepro commented 11 months ago

No, even when the F3 menu isn't open, the two are rendered differently. With NeoForge, it's rendered as an always visible part of the F3 menu (even when the F3 menu isn't opened).

Lolothepro commented 11 months ago

Neo: 2023-10-05_17 59 03

Vanilla: 2023-10-05_18 00 32

Shadows-of-Fire commented 11 months ago

Is this even an issue we should care about? Using Neo is conditional on owning the game; using Neo and the demo is an unsupported mix.

TelepathicGrunt commented 9 months ago

@sciwhiz12 Are you sure bug label even applies here? The neo version is better and honestly preferred imo. Makes me wonder if this was intentionally done in the first place

sciwhiz12 commented 9 months ago

On its face, this looks to be a change of behavior inconsistent with vanilla and doesn't seem to be intended, which is generally the criteria I use when labelling issues with https://github.com/neoforged/NeoForge/labels/bug. (The https://github.com/neoforged/NeoForge/labels/triage label is there to signal that the issue hasn't been triaged yet, i.e. considered at length if it's an actual bug or a bug worth fixing; I generally add labels first and triage later.)

Once someone (like me, or any other maintainer) makes the judgement call that this is a bug and it is worth fixing, i.e. triaging it, they can then remove the https://github.com/neoforged/NeoForge/labels/triage label and move it to the appropriate status in the Triage board.

On this matter, I'd like to check if this is intentional, and if we can make it so it renders in the vanilla-esque manner when the debug menu is disabled (with the current behavior left intact when the debug menu is visible).

Lolothepro commented 9 months ago

Since Minecraft 1.20.2, it's no longer rendered, which makes me think it's a bug. so it's probably not intentional

Lolothepro commented 9 months ago

NeoForge: 2023-12-10_11 18 22

Vanilla: 2023-12-10_12 19 33

TelepathicGrunt commented 9 months ago

Issue is the demo overlay is not in VanillaGuiOverlay class