search

neoforged / NeoForge

Neo Modding API for Minecraft, based on Forge
https://neoforged.net
Other
1.24k stars 179 forks source link

[1.21.3] `TagsUpdatedEvent` does not fire on clients after connecting to a dedicated server #1694

Open Fuzss opened 3 days ago

Fuzss commented 3 days ago

Minecraft Version: 1.21.3

NeoForge Version: 21.3.34

There is simply a patch missing for firing the event in ClientConfigurationPacketListenerImpl.

Fabric patches their callback in at the lambda passed to ClientConfigurationPacketListenerImpl::runWithResources in ClientConfigurationPacketListenerImpl::handleConfigurationFinished just after RegistryDataCollector::collectGameRegistries is called.

Currently the event only fires in ClientPacketListener::handleUpdateTags on the client-side, which only seems to handle data reloads, but not the initial load when joining.