neoforged / NeoForge

Neo Modding API for Minecraft, based on Forge
https://projects.neoforged.net/neoforged/neoforge
Other
1.1k stars 161 forks source link

If a loading error occurs (ie: bad depency), and Oculus/Iris is present, the error will not be displayed, and the game will crash, blaming Oculus. #195

Closed Lolothepro closed 9 months ago

Lolothepro commented 9 months ago

Oculus discord: image

Example with Iris and Forge: https://mclo.gs/Gho52SG

Loading error: [main/ERROR] [ne.mi.fm.lo.LanguageLoadingProvider/LOADING]: Missing language kotlinforforge version [1,) wanted by Resourcify (1.20-1.20.1-forge)-1.2.1.jar

Current crash message:

java.lang.IncompatibleClassChangeError: class net.coderbot.iris.gui.option.ShadowDistanceOption cannot inherit from final class net.minecraft.client.OptionInstance

Technici4n commented 9 months ago

The problem here is ATs being turned off when a dependency error occurs, but not core mods. Either we should find a way to turn AT back on, or we should find a way to turn off core mods. Personally I'd prefer the latter option.

XFactHD commented 9 months ago

Fixed by https://github.com/neoforged/FancyModLoader/pull/31.

Lolothepro commented 9 months ago

I forgot to close it myself