My thought is, this is weird and not very logical. Could we please see if it is ok to just yeet that patch entirely? Turn forge:stone into a normal convention tag right now. Then I can update my unify tag PR to match that decision.
If people want their stop block to be seen and replaced by worldgen features using the isStone method, they should add their stones to minecraft:base_stone_overworld tag. All the functionality of that Minecraft tag can be seen here (all of its usage is merely for checking if a block is in the tag):
https://minecraft.wiki/w/Tag#Blocks
In this patch file,
forge:stone
is forcibly replacingminecraft:base_stone_overworld
tag and thus, stealing one functionality from that Minecraft tag for the Forge tag. https://github.com/neoforged/NeoForge/blob/1.20.x/patches/net/minecraft/world/level/levelgen/feature/Feature.java.patchMy thought is, this is weird and not very logical. Could we please see if it is ok to just yeet that patch entirely? Turn
forge:stone
into a normal convention tag right now. Then I can update my unify tag PR to match that decision.If people want their stop block to be seen and replaced by worldgen features using the isStone method, they should add their stones to
https://minecraft.wiki/w/Tag#Blocks
minecraft:base_stone_overworld
tag. All the functionality of that Minecraft tag can be seen here (all of its usage is merely for checking if a block is in the tag):