search

neoforged / NeoForge

Neo Modding API for Minecraft, based on Forge
https://projects.neoforged.net/neoforged/neoforge
Other
1.1k stars 161 forks source link

Can `forge:stone` tag stop being patched into Feature class? #273

Closed TelepathicGrunt closed 9 months ago

TelepathicGrunt commented 9 months ago

In this patch file, forge:stone is forcibly replacing minecraft:base_stone_overworld tag and thus, stealing one functionality from that Minecraft tag for the Forge tag. https://github.com/neoforged/NeoForge/blob/1.20.x/patches/net/minecraft/world/level/levelgen/feature/Feature.java.patch

My thought is, this is weird and not very logical. Could we please see if it is ok to just yeet that patch entirely? Turn forge:stone into a normal convention tag right now. Then I can update my unify tag PR to match that decision.

If people want their stop block to be seen and replaced by worldgen features using the isStone method, they should add their stones to minecraft:base_stone_overworld tag. All the functionality of that Minecraft tag can be seen here (all of its usage is merely for checking if a block is in the tag): image https://minecraft.wiki/w/Tag#Blocks

TelepathicGrunt commented 9 months ago

We decided in discord to just remove the patch entirely as part of the unify tag pr work https://discord.com/channels/313125603924639766/852298000042164244/1175093684631515227