search

neoforged / NeoForge

Neo Modding API for Minecraft, based on Forge
https://projects.neoforged.net/neoforged/neoforge
Other
1.22k stars 178 forks source link

Mods screen 'Illegal format found' #734

Closed ApexModder closed 6 months ago

ApexModder commented 7 months ago

Minecraft Version: 20.4/5

NeoForge Version: 20.4.184 / 20.5.0-alpha.24w12a [local build]

Steps to Reproduce:

  1. Set mod name to something with a ' (Fantasy's Dice)
  2. Launch game and open the mods screen
  3. Console will spam something like the following [18:36:30] [Render thread/ERROR] [ne.ne.ne.co.I18nExtension/CORE]: Illegal format found Fantasy's Dice

Description of issue: When including a ' in your mods name for possessiveness it causes a illegal format issue when opening the mods screen, and possibly anywhere else which references the mods name.

Break points seem to show that the game is thinking its a unterminated string, but shouldn't it be looking for " for string terminations? I am using ' for possessiveness in my mods name.

Extended conversation in Neo-cord

Break point of error/exception ![image](https://github.com/neoforged/NeoForge/assets/29412632/6a6c0e5f-91ed-4d3a-afd0-baf609023fd1)
embeddedt commented 6 months ago

This was fixed by https://github.com/neoforged/NeoForge/pull/851 for 1.20.5 and https://github.com/neoforged/NeoForge/pull/686 for 1.20.4.