search

neoforged / NeoForge

Neo Modding API for Minecraft, based on Forge
https://projects.neoforged.net/neoforged/neoforge
Other
1.14k stars 165 forks source link

rare random Crafting Issue #795

Closed MSandro closed 2 months ago

MSandro commented 5 months ago

Minecraft Version: 1.20.4 NeoForge Version: 20.4.227

I'm really not sure if it's a problem directly with NeoForge. I've already reported the bug to a few mods. In rare cases something seems to go wrong when loading recipes. I can rarely reproduce it. I've spent many hours over the last few days trying to get to the bottom of the problem, but to no avail, I can't pinpoint an exact mod that might be to blame. The more mods are loaded, the more often it occurs.

Steps to Reproduce:

  1. Join a world
  2. put something in the crafting grid
  3. sometimes you will get a random item as output

Description of issue: image image image

MSandro commented 5 months ago

All of these issues are related to this: https://github.com/mekanism/Mekanism/issues/8056 https://github.com/TeamTwilight/twilightforest/issues/2022 https://github.com/AztechMC/Modern-Industrialization/issues/694 https://github.com/Glitchfiend/ToughAsNails/issues/843

shartte commented 5 months ago

There was this Mojang bug I reported ages ago that was fixed a while back: https://bugs.mojang.com/browse/MC-244550

Did this get revived somehow?

Technici4n commented 5 months ago

It's probably due to our isEmpty ingredient patch + some bad luck?

MSandro commented 5 months ago

I have tried a mod which should be able to fix tag related issues: https://www.curseforge.com/minecraft/mc-mods/lmft but it did not work.

Now I've noticed that some items don't have tags when the issue occurs: image Here's what it looks like if the recipes are okay: image

MSandro commented 5 months ago

I've noticed the same issue in this Modpack: https://www.curseforge.com/minecraft/modpacks/new-game-neoforge-version

But there is no tech mod like Mekanism or Modern Industrialization. It is more like a large Vanilla+ Modpack.

image image image image

The only mod that is also in my modpacks is Twilight Forest.

Shadows-of-Fire commented 5 months ago

Will be worth tracking the status of this after https://github.com/neoforged/NeoForge/pull/793 to see if it still occurs, since it is obviously from some transient issue within the ingredient code.

Technici4n commented 2 months ago

Let's assume that the ingredient rework fixed this in 1.20.5+. If not, please let us now.