search

neoforged / NeoForge

Neo Modding API for Minecraft, based on Forge
https://projects.neoforged.net/neoforged/neoforge
Other
1.17k stars 172 forks source link

Eye of Ender items behave differently than vanilla. #796

Open Chuzume opened 5 months ago

Chuzume commented 5 months ago

Minecraft Version: 1.20.4

NeoForge Version: 20.4.227

Description of issue: In vanilla Minecraft, using the Eye of Ender in a world without stronghold slows down the player and triggering the Advancement "using_item" without consuming the item, but in NeoForge this Advancement cannot be triggered.

There are a few data packs that use the Eye of Ender trigger, but these will no longer work in NeoForge. Also, this has been confirmed since Forge.

In vanilla

In Neo Forge

Shadows-of-Fire commented 5 months ago

How do you generate a world without a stronghold? Resolved via datapack

Shadows-of-Fire commented 5 months ago

This is caused by a bugfix that forge has in place for https://bugs.mojang.com/browse/MC-107185

Our policy for vanilla bugfixes is to keep them in place unless major detrimental issues arise (i.e. https://github.com/MinecraftForge/MinecraftForge/issues/9309); as such, we will keep this fix, though the patch for it (below) needs to be updated to explicitly reflect the bug that it is fixing (as it currently does not).

https://github.com/neoforged/NeoForge/blob/a7edbae3979ec3aa755e9f68ab59fb35e6d785dc/patches/net/minecraft/world/entity/LivingEntity.java.patch#L510-L511

Leaving this issue open for the time being as a reminder to add the bug reference.

tmvkrpxl0 commented 5 months ago

~How do you generate a world without a stronghold?~ Resolved via datapack

Btw flat world would've worked as well

TelepathicGrunt commented 4 months ago

@Shadows-of-Fire what about the advancement part of the issue?

triggering the Advancement "using_item" without consuming the item, but in NeoForge this Advancement cannot be triggered.

If using the item doesn't trigger the advancement like vanilla does, then the patch will need a slight adjustment to fire the use advancement without slowing the player down.

Shadows-of-Fire commented 4 months ago

There's no way to keep the patch and maintain the behavior that triggers the particular advancement - the fact that it triggers at all is a bug (as indicated by Mojang), which means this behavior could stop functioning in any MC release.

TelepathicGrunt commented 2 months ago

@Shadows-of-Fire I am not sure I agree that the advancement firing is a bug. The slowdown is. But if I right click to send up an Eyes of Ender, that's using the item from the player's perspective and should trigger the advancement. I feel mojang would be more likely to find a way to separate the slowdown away from the advancement triggering so the advancement still fires. How they do that, no idea. Might not be solvable easily on our side either.