neoforged / websites

Official website for NeoForged
https://neoforged.net
Creative Commons Attribution 4.0 International
4 stars 16 forks source link

some style changes and fixes #34

Closed UltimatChamp closed 1 month ago

UltimatChamp commented 2 months ago

Preview URL: https://pr-34.neoforged-website-previews.pages.dev

neoforged-pages-deployments[bot] commented 2 months ago

Deploying with Cloudflare Pages

Name Result
Last commit: a165d5d0182a6e8b42434293189d1c14540e1098
Status: ✅ Deploy successful!
Preview URL: https://8558016f.neoforged-website-previews.pages.dev
PR Preview URL: https://pr-34.neoforged-website-previews.pages.dev
UltimatChamp commented 1 month ago

Hmm... I'll revert the changes you asked in a bit. It'll be nice if someone could make a better fullscreen solution; the current one is just pretty bugging.

ChampionAsh5357 commented 1 month ago

The transition and dimming effect on the version bar makes it look like the option is greyed out while also having the colors meld together, making it look washy. Could we remove the transition to see whether the effect looks better. If it still has a similar issue, I would suggest removing the transition and dimming effect for the bar altogether and just leaving the border around the version bar to indicate selection.

Non-hovered: image

Hovered: image

UltimatChamp commented 1 month ago

Ok!

Also, I'll record some visual representations of the changes you and Sci have asked for better comparison. (and btw the highlight and the versions dropdowns were made pr-ed by me; just reading project-talk on discord lol)

the transition effect is already not on neoforged.net

UltimatChamp commented 1 month ago
UltimatChamp commented 1 month ago

Should I do this?

https://github.com/neoforged/websites/assets/140878474/4af0adbb-13dc-4eb9-99a2-de7953f745f2

sciwhiz12 commented 1 month ago

Should I do this? rec_neo2.mp4

I think that's too distracting, personally.

UltimatChamp commented 1 month ago

what about now?