search

neogeno / shango-lightning-wallet

Shango Lightning Wallet
66 stars 4 forks source link

Be able to change amount in LN request with value 0 #76

Closed J4K0B closed 5 years ago

J4K0B commented 5 years ago

Thank you for trying out Shango Beta.

Please submit your issues with the following information

Expected Behavior

After scanning an invoice with value / amount of 0, I should be able to change the value.

Current Behavior

I cannot change the value. I need to be able to do this for donations on tippin.me for example.

Possible Solution or Best way to handle this problem

In src/components/paycard.js in onSuccess(qr) add an if statement which checks if the paymentRequestResponse.numSatoshis equals 0, if so don't disable the editing.

Steps to Reproduce

  1. try to tip someone at tippin.me
  2. scan the qr invoice
  3. now you can't specify the amount you want to donate to the person
J4K0B commented 5 years ago

(unrelated) Also, why don't you open source the whole source code and not just the component src?

neogeno commented 5 years ago

Will be tidying up and release the entire code base along with contribution guidelines

neogeno commented 5 years ago

This was fixed in Build 54 now. Please let me know if it works!