search

neojato / DeLorean-v2

A Professional Template for large GDG events. This project has been designed to continue to be your DevFest/IWD website solution without having to create a new site or Firebase project every year.
https://delorean-demo.firebaseapp.com
MIT License
46 stars 54 forks source link

New projects and missing urls cause /null links #32

Closed cjwhitsitt closed 5 years ago

cjwhitsitt commented 5 years ago

Expected Behavior

When creating a new project that doesn't have webpages for tickets or sponsors, there shouldn't be broken links.

Current Behavior

Currently, the ticket link is required but still read by two buttons on the home page (menu and hero). The sponsor button also continues to display even when the sponsor url is missing.

Possible Solution

  1. Hide the buttons if their url is missing regardless of if the url is required or not
  2. Don't show some pages if urls are missing
cjwhitsitt commented 5 years ago

I'd prefer to just hide the buttons. Doing it this way also provides the site owner a way to disable the ticket or sponsor buttons after the event if they'd like.

neojato commented 5 years ago

Wasn't able to replicate on the sponsor button (already is being hidden), but disabled the Ticket button in hero until added in Site Config.