neojjang / dashclock

Automatically exported from code.google.com/p/dashclock
0 stars 0 forks source link

DragSort build error #495

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Building the app with ant and using dragsort (from source) at 0.6.1 produces 
the following error: -compile:
    [javac] Compiling 62 source files to /home/gerry/build/srclib/DashClock/main/src/main/bin/classes
    [javac] /home/gerry/build/srclib/DashClock/main/src/main/java/com/google/android/apps/dashclock/configuration/ConfigureExtensionsFragment.java:175: error: ';' expected
    [javac]                 return dragSortController.onTouch(view, motionEvent)
    [javac]                                                                     ^
    [javac] 1 error
==== stdout end ====
==== stderr begin ====

So it looks like the aar is not exactly built from the source of 0.6.1. If so, 
could you publish any changes you made before building the library? Gradle is 
all very well but if it means less transparency around source code then 
arguably it is making us take a step back.

Original issue reported on code.google.com by david8bl...@gmail.com on 21 Jun 2013 at 11:32

GoogleCodeExporter commented 8 years ago
Hmm, I don't recall making any changes to the code but I'll check.

Looking at the DSLV 0.6.1 code now,  I do see onTouch:

https://github.com/bauerca/drag-sort-listview/blob/0.6.1/library/src/com/mobeta/
android/dslv/DragSortController.java#L238

What's the specific error, does it think the method doesn't exist? Seems more 
like a syntax error.

Original comment by roman.nurik on 21 Jun 2013 at 5:28

GoogleCodeExporter commented 8 years ago
I'm sorry, I posted the wrong error above:

 /home/gerry/fdroiddata/build/srclib/DashClock/main/src/main/java/com/google/android/apps/dashclock/configuration/ConfigureExtensionsFragment.java:176: error: cannot find symbol
    [javac]                         || (!dragSortController.isDragging()
    [javac]                                                ^
    [javac]   symbol:   method isDragging()
    [javac]   location: variable dragSortController of type DragSortController
    [javac] Note: Some input files use or override a deprecated API.

Original comment by david8bl...@gmail.com on 23 Jun 2013 at 9:54

GoogleCodeExporter commented 8 years ago
Ah, I must've exposed an extra method to make it work with the 
swipe-to-dismiss. Will fix somehow.

Original comment by roman.nurik on 23 Jun 2013 at 4:23