neojxuan / pe

0 stars 0 forks source link

Names are too restrictive #11

Open neojxuan opened 2 years ago

neojxuan commented 2 years ago

Many valid names contain non-alphanumeric characters like hyphens, apostrophes (O'Brien) and full stops can be used to shorten names as well (like Mohd.).

nus-pe-bot commented 2 years ago

Team's Response

Thank you for the response :) However, as our app specifically mentions that we are implementing the name feature with only alphanumeric characters. This is because we need to draw the boundary of valid names to be accepted as otherwise, the lack of support for Chinese characters and Arabic characters, for example, can be argued as feature flaws too. Hence, for the initial working version of our app in the context of CS2103T, alphanumeric characters suffice.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: 1. Names written with the English alphabet often include hyphens (e.g. Cherie-Anne), apostrophes (e.g. O'Brien) and slashes (e.g. s/o).

  1. It would not take a lot of work to allow these common characters in names. Hence, I believe this can be classified as a feature flaw and not NotInScope according to the second paragraph below ("Similarly...").

image.png

  1. I understand that the app is meant for Singaporeans, and to be used in English, hence I would not point out the lack of support for Chinese/Arabic characters as a feature flaw. However, the characters that are not allowed in the app are characters that are present in English names.