search

neojxuan / pe

0 stars 0 forks source link

Phone numbers restrictions are too strict #5

Open neojxuan opened 2 years ago

neojxuan commented 2 years ago

Phone numbers do not allow valid characters like + for +65 69701234, or for overseas numbers should there be patients from overseas and extensions. They are also limited to 8 digits, which may not be necessary.

nus-pe-bot commented 2 years ago

Team's Response

Thank you for the response :), this is a duplicate issue

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Phone numbers only accept 8 digits

Certain phone numbers may be more than 8 digits long (if you include country code).

Burner phones might come with a number +65. The app also does not specify the nationalities of the target audience. Overseas numbers might be longer than 8 digits.

image.png

[original: nus-cs2103-AY2122S1/pe-interim#4744] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for the response :) However, we have decided to reject this bug report as we have already mentioned in the NFR section of our DG that the target users of our app are Singapore users. As per the national convention, Singapore phone numbers are exactly 8 digits long and do not require an area code, since the app is only being used within Singapore.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: 1. Users can be based in Singapore, yet want to add/edit contacts with overseas numbers. For example, their patients or colleagues may travel overseas.

  1. In the target user profile in the DG, there is no mention that users must be from Singapore. In the UG and DG intros, there is no mention that the target audience are Singaporeans as well.
  2. From the image below, the software is also unable to allow adding both home and office numbers (even if both are Singapore numbers) due to the very strict restrictions on length and accepted input of phone number. As mentioned in my original report, it is not necessary to limit phone numbers to 8 digits only. image.png