search

neojxuan / pe

0 stars 0 forks source link

Wrong example edit command #6

Open neojxuan opened 3 years ago

neojxuan commented 3 years ago

edit t/patient i/P002 n/John Snow p/91234567 a/30 b/AB g/M h/185 w/85 m/cancer should be AB+

nus-pe-bot commented 3 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Add command in user guide contains invalid blood type

image.png

The above command provided in the quick start section of user guide doesn't work. The screenshot below displays the output returned when this command is inputted.

image.png

The specified example in the user guide is incorrect even though the description of the parameters specify the acceptable blood types. I classify this as a documentation bug as it is an incorrect example in spite of the functionality specified. This could be of medium severity as new users would experience difficulties in adding a patient. Another example with incorrect blood type parameters in the guide is in the screenshot below.

image.png

[original: nus-cs2103-AY2122S1/pe-interim#4526] [original labels: severity.Medium type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for the response :). The correct information was given in the constraints summary in the UG and the error message in the app itself, and therefore should not affect the normal operations of the app. It only causes minor inconvenience upon copy pasting for the first time.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Although the same problem is present in both commands (invalid blood type), they cannot be counted as duplicates as these two commands are very different and appear in different sections/features of the user guide (one under add patient and one under edit patient). The example commands are also quite different:

  1. add t/patient n/John Smith p/98765432 a/45 b/AB g/M h/175 w/70 m/heart failure m/diabetes
  2. edit t/patient i/P002 n/John Snow p/91234567 a/30 b/AB g/M h/185 w/85 m/cancer

These commands are not the same and they can be fixed independently.

:question: Issue severity

Team chose [severity.Low] Originally [severity.VeryLow]

Reason for disagreement: [replace this with your explanation]