search

neomantra / docker-onload

Docker tooling for Solarflare's OpenOnload
https://hub.docker.com/r/neomantra/onload/
MIT License
25 stars 9 forks source link

(centos6) md5sum expects 2 spaces between checksum and input file #1

Closed mkst closed 5 years ago

mkst commented 5 years ago

Trying to build from a centos:6.7 base with

docker build . -f centos/Dockerfile --build-arg ONLOAD_CENTOS_TAG=6.7

errors with:

md5sum: standard input: no properly formatted MD5 checksum lines found

As per https://forum.openoffice.org/en/forum/viewtopic.php?f=16&t=83825 this is due to md5sum expecting 2 spaces (rather than 1), e.g. line 63 should be:

    && echo "${ONLOAD_MD5SUM}  openonload-${ONLOAD_VERSION}.tgz" | md5sum --check \

I'll fork and submit a PR if desired.

neomantra commented 5 years ago

It looks like Centos 6 and Centos 7 md5sum commands both accept the two spaces, so I'll add a space.

In creating these Dockerfiles, other md5sum programs (maybe for older Debian) wanted that formatting. I made all this MD5 checking because Solarflare provided checksums but didn't protect openonload.org with HTTPS -- now they do.

neomantra commented 5 years ago

OK, that's on master. Thanks again... happy kernel-bypassing!

mkst commented 5 years ago

Thanks! I'm still in the early stages of spinning up docker on a box with a solarflare card - this repo looks to be a great bootstrap for that. If I encounter anything else I'll let you know :)