search

neomatrix369 / awesome-ai-ml-dl

Awesome Artificial Intelligence, Machine Learning and Deep Learning as we learn it. Study notes and a curated list of awesome resources of such topics.
Other
1.47k stars 352 forks source link

optimize: Optimizes All Images By 49.37% #100

Closed PrynsTag closed 3 years ago

PrynsTag commented 3 years ago

I optimized all your images for you and saved 49.37% of space.

neomatrix369 commented 3 years ago

Hey Thanks for doing this @PrynsTag, can you please share some screenshots of the after-effects of this optimisation?

neomatrix369 commented 3 years ago

One suggestion I would like to make and it will make both of our lives easier - to split this PR into smaller PRs so we can verify the changes images are the same and we haven't regressed

PrynsTag commented 3 years ago

Your welcome! As per your 2nd request in splitting this PR, this PR is reliant on ImgBot and is generated automatically. I have read their documentation here however they are not providing such configuration. I have also looked at other PR of ImgBot to quantify what I have said:

However the issue is the same.

Your first request is integrated in GitHub. Just go to the "Files Changed Section" shown bellow image

And then click the document icon image

After that you are presented with split view (by default) on what's been deleted and what's been added. image

PrynsTag commented 3 years ago

I am still fairly new to ImgBot and PR and would want to learn so if you still have any concerns don't hesitate to tell me.

neomatrix369 commented 3 years ago

I am still fairly new to ImgBot and PR and would want to learn so if you still have any concerns don't hesitate to tell me.

I'm fine with whatever method you use to go about further, as long as we know that the optimised images are the same and are visible like they did before the optimisation.

Could you try to go thru them and see if this is the case, and let me know, thanks for the screenshots of the others above.

neomatrix369 commented 3 years ago

I have viewed the 47 images and I can confirm that the PR didn't break the image and the quality of the images is not reduced.

Thanks @PrynsTag!