Closed EduardErnest closed 3 years ago
Hey mani, yes , I will try to the the changes you specified when I get a moment :) on my laptop, thanks for pointing that out.
On 16 May 2020, at 11:27, mani notifications@github.com wrote:
@neomatrix369 requested changes on this pull request.
Thanks for the contribution, good work.
Could you please see my comments and let me know if you are able to amend the PR, thanks.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/neomatrix369/awesome-ai-ml-dl/pull/73#pullrequestreview-413066228, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCO52XHMUZIRZ42CWAAO7DRRZTCFANCNFSM4NC2LKRA.
Hey mani, yes , I will try to the the changes you specified when I get a moment :) on my laptop, thanks for pointing that out. …
Here is a good example https://github.com/neomatrix369/awesome-ai-ml-dl/pull/72, and if you see some other PRs from the past (look at closed PRs), you can see how it is done.
Once you do a couple you will become used to it ;)
Yes, I am not a pro, im actually a beginner in git, took me a while to fork this and pull it back to u, had some guidance, but it was really good exercise.
I will look it up and try to make the changes you specified :))
On 16 May 2020, at 11:44, mani notifications@github.com wrote:
Hey mani, yes , I will try to the the changes you specified when I get a moment :) on my laptop, thanks for pointing that out. … <x-msg://2/#> On 16 May 2020, at 11:27, mani @.***> wrote: @neomatrix369 https://github.com/neomatrix369 requested changes on this pull request. Thanks for the contribution, good work. Could you please see my comments and let me know if you are able to amend the PR, thanks. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#73 (review) https://github.com/neomatrix369/awesome-ai-ml-dl/pull/73#pullrequestreview-413066228>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCO52XHMUZIRZ42CWAAO7DRRZTCFANCNFSM4NC2LKRA https://github.com/notifications/unsubscribe-auth/ALCO52XHMUZIRZ42CWAAO7DRRZTCFANCNFSM4NC2LKRA.
Here is a good example #72 https://github.com/neomatrix369/awesome-ai-ml-dl/pull/72, and if you see some other PRs from the past (look at closed PRs), you can see how it is done.
Once you do a couple you will become used to it ;)
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/neomatrix369/awesome-ai-ml-dl/pull/73#issuecomment-629626177, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCO52ROMDJ7AJ2E4QXOKALRRZVB3ANCNFSM4NC2LKRA.
Yes, I am not a pro, im actually a beginner in git, took me a while to fork this and pull it back to u, had some guidance, but it was really good exercise. I will look it up and try to make the changes you specified :)) …
It's a good opportunity to learn how to do it, good efforts made - well done.
@darkprince266 have a look at this branch - https://github.com/neomatrix369/awesome-ai-ml-dl/tree/add-explaianble-ai-links (see commit https://github.com/neomatrix369/awesome-ai-ml-dl/commit/099ce44c5e693c169b2f962c221388d15d43cb67)- you can see how I have made placeholders for the PDFs you want to link on this repo. You will have to find out how to add links via markdown in order to make that happen.
Try to see if you can do the same on a new PR and resubmit (we can close this PR then).
@darkprince266 have you had a chance to look at the example I created, it shouldnt take you much to fix up the PR
Ok , Sozz many , I will sort it out.
On Mon, 18 May 2020 at 16:35, mani notifications@github.com wrote:
@darkprince266 https://github.com/darkprince266 have a look at the commit on this branch - https://github.com/neomatrix369/awesome-ai-ml-dl/tree/add-explaianble-ai-links
You can see how I have made placeholders for the PDFs you want to link on this repo. You will have to find out how to add links via markdown in order to make that happen.
Try to see if you can do the same on a new PR and resubmit (we can close this PR then).
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/neomatrix369/awesome-ai-ml-dl/pull/73#issuecomment-630262913, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCO52VE5XRZUHAZQLSOVPLRSFITTANCNFSM4NC2LKRA .
@darkprince266 Hey Eduardo I guess you are busy - pls suggest what we could do to see some progress on this PR
This PR has been fulfilled via commit 35aead3 hence closing it
Thank you @EduardErnest for your contributions, I have published it via the Release system, see https://github.com/neomatrix369/awesome-ai-ml-dl/releases/tag/v0.1 (Under assets, you should find the PDF files) and if you look here you will see here https://github.com/neomatrix369/awesome-ai-ml-dl/blob/master/data/model-analysis-interpretation-explainability.md#articles-blog-posts-papers-notebooks-books-presentations (towards the bottom of the section) ❤️ 😍
@darkprince266 do you mind putting links to the paper instead of the binary PDF file if possible.
Also, you can create hyperlinks to these PDF files and add them to one or more sections on the repo.
See here how the links are laid out in https://github.com/neomatrix369/awesome-ai-ml-dl/blob/master/data/model-analysis-interpretation-explainability.md, you can place them under multiple category depending on which ones they apply to.
Also take a look at other sections in the repo, to know where else it could be applicable.