neomatrix369 / nlp_profiler

A simple NLP library allows profiling datasets with one or more text columns. When given a dataset and a column name containing text data, NLP Profiler will return either high-level insights or low-level/granular statistical information about the text in that column.

Other

243 stars 37 forks source link

correct "words_count" to "count_words" in code block #18

Closed jammy-bot closed 4 years ago

jammy-bot commented 4 years ago

"count_words" method is misnamed, in the "Words count" section's code block

neomatrix369 commented 4 years ago

@jammy-bot Good spot, and thank you for your PR

I will review it and get back to you soon

neomatrix369 commented 4 years ago

Please run the test coverage shell script to see if there are other changes to be made:

./test-coverage.sh "tests slow-tests"

jammy-bot commented 4 years ago

Cool...and that should look like the following @neomatrix369 (y/n?) :

git remote add upstream https://github.com/neomatrix369/nlp_profiler
git fetch upstream
git checkout master
git rebase upstream/master
git push origin master

neomatrix369 commented 4 years ago

Cool...and that should look like the following @neomatrix369 (y/n?) :

git remote add upstream https://github.com/neomatrix369/nlp_profiler

git fetch upstream

git checkout master

git rebase upstream/master

git push origin master

Sounds about right, in addition to that you need to do this:

git checkout correct-count-words
git rebase master
git push origin correct-count-words

That's when this branch will get updated and it will save you all the manual steps you need to do to check if your changes work or not.

jammy-bot commented 4 years ago

It's my first time at the rodeo. Let me know if I missed anything. Do I close this out?

Awesome work, by the way!

neomatrix369 commented 4 years ago

It's my first time at the rodeo. Let me know if I missed anything. Do I close this out?

Awesome work, by the way!

No you don't close out on the PR, I have reopened it. Let the Github action run and do the rest of the steps for us before we know what to do next

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d861ac6). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             master       #18   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?        20           
  Lines             ?       358           
  Branches          ?        51           
==========================================
  Hits              ?       358           
  Misses            ?         0           
  Partials          ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d861ac6...ed17c9c. Read the comment docs.

neomatrix369 commented 4 years ago

@jammy-bot Can you please regenerate the two notebooks in the notebooks/jupyter folder:

nlp_profiler-granular.ipynb
nlp_profiler.ipynb

Since your changes result in these two notebooks to go a bit out of sync - which is normal but the change is a small one.

jammy-bot commented 4 years ago

Sure thing. I started to just save and commit them from local, but I should probably redo to commit the colab notebook from colab.

neomatrix369 commented 4 years ago

Sure thing. I started to just save and commit them from local, but I should probably redo to commit the colab notebook from colab.

Okay sounds good, the Jupyter notebook is the same in content, so you could just copy it over.

jammy-bot commented 4 years ago

Sorry for the trouble. I no longer see the branch. Should I recreate it?

neomatrix369 commented 4 years ago

Sorry for the trouble. I no longer see the branch. Should I recreate it?

No worries, I'll merge the branch for now but rebase from master to complete the rest of the changes (if any is pending)

neomatrix369 commented 4 years ago

Please apply the same changes you applied to the colab-version, also the Jupyter version, see my previous comment https://github.com/neomatrix369/nlp_profiler/pull/18#issuecomment-709594373

neomatrix369 commented 4 years ago

I think your changes are not in this branch, can you please redo them, create a new branch and then a PR?

The original commits are missing, please have a look at the developer guide as well.