correct method-call to count_words

[jammy-bot]

correct from words_count

[codecov-io]

Codecov Report

Merging #23 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          358       358           
  Branches        51        51           
=========================================
  Hits           358       358           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 797c2a9...9d523ba. Read the comment docs.

[neomatrix369]

Code changes are not present, can you please redo them?

[neomatrix369]

You are going the wrong way around with this, this is how best to approach:

• make code changes in a new branch
• (default approach)
  • run Jupyter notebook/labs in the root of the project folder (outside the notebooks folder)
  • load the relevant notebook(s) from notebooks/jupyter/
  • run all the cells of the notebook(s)
  • save the notebook(s)
• (in your case)
  • open all the notebooks in a text editor
  • search for "word_counts" and replace with "count_words" in all the notebooks
  • save all notebooks and close editor
  • verify the above changes in the git diff view
• commit the changes to the branch
• push the branch to make a new Pull Request

In this instance please leave the Colab notebooks for me to update, I will introduce some automation so we can do it seamlessly in the future.

You can see there is not semantic difference between the notebooks in the notebooks/jupyter and notebooks/google-colab folders, except that the notebooks in notebooks/google-colab folder have an extra cell or two to help it to be identified as a Google colab notebook. Use the diff command or the IDE's file comparison features to find out.

[neomatrix369]

@jammy-bot I think all the count_words related changes have been applied to master, have a look again if you think it's not the case. We can close this PR in any case - good work and effort bringing it to my notice. It has opened up other areas that need a bit of tidying up

Feel free to pick a new issue from the Issues section or if you have found something else

[neomatrix369]

@jammy-bot let's close this PR for now and start fresh, please also have a look at Git and Github docs, especially branch managements, rebasing and merge conflicts aspects