Closed sourcery-ai[bot] closed 4 years ago
✅ Merging this PR will increase code quality in the affected files by 0.31%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 1.00 ⭐ | 1.00 ⭐ | 0.00 |
Method Length | 35.48 ⭐ | 35.10 ⭐ | -0.38 👍 |
Working memory | 5.76 ⭐ | 5.67 ⭐ | -0.09 👍 |
Quality | 87.71% ⭐ | 88.02% ⭐ | 0.31% 👍 |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 205 | 203 | -2 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
nlp_profiler/numbers.py | 95.63% ⭐ | 96.67% ⭐ | 1.04% 👍 |
nlp_profiler/sentiment_polarity.py | 85.57% ⭐ | 85.63% ⭐ | 0.06% 👍 |
nlp_profiler/stop_words.py | 91.41% ⭐ | 92.43% ⭐ | 1.02% 👍 |
slow-tests/performance_tests/test_perf_grammar_check.py | 85.30% ⭐ | 85.30% ⭐ | 0.00% |
slow-tests/performance_tests/test_perf_spelling_check.py | 85.30% ⭐ | 85.30% ⭐ | 0.00% |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
slow-tests/performance_tests/test_perf_grammar_check.py | test_given_a_text_column_when_profiler_is_applied_with_high_level_analysis_then_it_finishes_quick | 2 ⭐ | 122 😞 | 12 😞 | 60.51% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
slow-tests/performance_tests/test_perf_spelling_check.py | test_given_a_text_column_when_profiler_is_applied_with_high_level_analysis_then_it_finishes_quick | 2 ⭐ | 122 😞 | 12 😞 | 60.51% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Let us know what you think of it by mentioning @sourcery-ai in a comment.
Merging #30 into refactor-generate-features-module will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## refactor-generate-features-module #30 +/- ##
===================================================================
Coverage 100.00% 100.00%
===================================================================
Files 21 21
Lines 360 358 -2
Branches 51 51
===================================================================
- Hits 360 358 -2
Impacted Files | Coverage Δ | |
---|---|---|
nlp_profiler/numbers.py | 100.00% <100.00%> (ø) |
|
nlp_profiler/sentiment_polarity.py | 100.00% <100.00%> (ø) |
|
nlp_profiler/stop_words.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 193f97a...8f6d048. Read the comment docs.
Branch
refactor-generate-features-module
refactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
refactor-generate-features-module
branch, then run: