Closed neomatrix369 closed 3 years ago
Merging this PR leaves code quality unchanged.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 0.58 ⭐ | 0.58 ⭐ | 0.00 |
Method Length | 29.40 ⭐ | 29.40 ⭐ | 0.00 |
Working memory | 6.05 ⭐ | 6.05 ⭐ | 0.00 |
Quality | 88.85% ⭐ | 88.85% ⭐ | 0.00% |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 1584 | 1584 | 0 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
setup.py | 53.63% 🙂 | 53.63% 🙂 | 0.00% |
nlp_profiler/init.py | 100.00% ⭐ | 100.00% ⭐ | 0.00% |
nlp_profiler/constants.py | 85.66% ⭐ | 85.66% ⭐ | 0.00% |
nlp_profiler/core.py | 71.16% 🙂 | 71.16% 🙂 | 0.00% |
nlp_profiler/generate_features/init.py | 85.18% ⭐ | 85.18% ⭐ | 0.00% |
nlp_profiler/generate_features/parallelisation_methods/init.py | 89.31% ⭐ | 89.31% ⭐ | 0.00% |
nlp_profiler/granular_features/init.py | 74.39% 🙂 | 74.39% 🙂 | 0.00% |
nlp_profiler/granular_features/alphanumeric.py | 96.67% ⭐ | 96.67% ⭐ | 0.00% |
nlp_profiler/granular_features/chars_and_spaces.py | 95.39% ⭐ | 95.39% ⭐ | 0.00% |
nlp_profiler/granular_features/dates.py | 93.13% ⭐ | 93.13% ⭐ | 0.00% |
nlp_profiler/granular_features/duplicates.py | 90.95% ⭐ | 90.95% ⭐ | 0.00% |
nlp_profiler/granular_features/emojis.py | 93.67% ⭐ | 93.67% ⭐ | 0.00% |
nlp_profiler/granular_features/non_alphanumeric.py | 96.67% ⭐ | 96.67% ⭐ | 0.00% |
nlp_profiler/granular_features/numbers.py | 96.67% ⭐ | 96.67% ⭐ | 0.00% |
nlp_profiler/granular_features/punctuations.py | 95.19% ⭐ | 95.19% ⭐ | 0.00% |
nlp_profiler/granular_features/sentences.py | 97.67% ⭐ | 97.67% ⭐ | 0.00% |
nlp_profiler/granular_features/stop_words.py | 92.43% ⭐ | 92.43% ⭐ | 0.00% |
nlp_profiler/granular_features/words.py | 96.67% ⭐ | 96.67% ⭐ | 0.00% |
nlp_profiler/high_level_features/init.py | 82.81% ⭐ | 82.81% ⭐ | 0.00% |
nlp_profiler/high_level_features/grammar_quality_check.py | 87.68% ⭐ | 87.68% ⭐ | 0.00% |
nlp_profiler/high_level_features/sentiment_polarity.py | 85.63% ⭐ | 85.63% ⭐ | 0.00% |
nlp_profiler/high_level_features/sentiment_subjectivity.py | 85.43% ⭐ | 85.43% ⭐ | 0.00% |
nlp_profiler/high_level_features/spelling_quality_check.py | 84.13% ⭐ | 84.13% ⭐ | 0.00% |
slow-tests/init.py | % | % | % |
slow-tests/acceptance_tests/init.py | % | % | % |
slow-tests/acceptance_tests/test_apply_text_profiling.py | 83.21% ⭐ | 83.21% ⭐ | 0.00% |
slow-tests/performance_tests/init.py | % | % | % |
slow-tests/performance_tests/common_functions.py | 94.11% ⭐ | 94.11% ⭐ | 0.00% |
slow-tests/performance_tests/test_perf_grammar_check.py | 75.16% ⭐ | 75.16% ⭐ | 0.00% |
slow-tests/performance_tests/test_perf_spelling_check.py | 75.16% ⭐ | 75.16% ⭐ | 0.00% |
tests/init.py | % | % | % |
tests/acceptance_tests/init.py | % | % | % |
tests/acceptance_tests/test_apply_text_profiling.py | 85.26% ⭐ | 85.26% ⭐ | 0.00% |
tests/granular/init.py | % | % | % |
tests/granular/test_alphanumeric.py | 88.96% ⭐ | 88.96% ⭐ | 0.00% |
tests/granular/test_chars_and_spaces.py | 95.62% ⭐ | 95.62% ⭐ | 0.00% |
tests/granular/test_dates.py | 91.72% ⭐ | 91.72% ⭐ | 0.00% |
tests/granular/test_duplicates.py | 92.53% ⭐ | 92.53% ⭐ | 0.00% |
tests/granular/test_emojis.py | 93.46% ⭐ | 93.46% ⭐ | 0.00% |
tests/granular/test_non_alphanumeric.py | 91.43% ⭐ | 91.43% ⭐ | 0.00% |
tests/granular/test_numbers.py | 93.50% ⭐ | 93.50% ⭐ | 0.00% |
tests/granular/test_punctuations.py | 90.75% ⭐ | 90.75% ⭐ | 0.00% |
tests/granular/test_sentences.py | 81.39% ⭐ | 81.39% ⭐ | 0.00% |
tests/granular/test_stop_words.py | 93.46% ⭐ | 93.46% ⭐ | 0.00% |
tests/granular/test_words.py | 92.03% ⭐ | 92.03% ⭐ | 0.00% |
tests/high_level/init.py | % | % | % |
tests/high_level/test_grammar_check.py | 87.02% ⭐ | 87.02% ⭐ | 0.00% |
tests/high_level/test_sentiment_polarity.py | 79.63% ⭐ | 79.63% ⭐ | 0.00% |
tests/high_level/test_sentiment_subjectivity.py | 79.63% ⭐ | 79.63% ⭐ | 0.00% |
tests/high_level/test_spelling_check.py | 75.75% ⭐ | 75.75% ⭐ | 0.00% |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
nlp_profiler/core.py | apply_text_profiling | 4 ⭐ | 133 😞 | 16 ⛔ | 51.83% 🙂 | Try splitting into smaller methods. Extract out complex expressions |
nlp_profiler/granular_features/init.py | apply_granular_features | 0 | 70 🙂 | 31 ⛔ | 57.70% 🙂 | Extract out complex expressions |
slow-tests/performance_tests/test_perf_grammar_check.py | test_given_a_text_column_when_profiler_is_applied_with_high_level_analysis_then_it_finishes_quick | 2 ⭐ | 113 🙂 | 13 😞 | 60.07% 🙂 | Extract out complex expressions |
slow-tests/performance_tests/test_perf_spelling_check.py | test_given_a_text_column_when_profiler_is_applied_with_high_level_analysis_then_it_finishes_quick | 2 ⭐ | 113 🙂 | 13 😞 | 60.07% 🙂 | Extract out complex expressions |
tests/granular/test_sentences.py | test_given_a_text_with_sentences_when_counted_then_return_the_count_of_sentences | 0 | 58 ⭐ | 18 ⛔ | 64.36% 🙂 | Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Let us know what you think of it by mentioning @sourcery-ai in a comment.
Merging #38 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #38 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 358 358
Branches 51 51
=========================================
Hits 358 358
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1db07ca...2344c7c. Read the comment docs.
Github templates: moving the pull request template into the .github folder and giving it the expected name