neomatrix369 / nlp_profiler

A simple NLP library allows profiling datasets with one or more text columns. When given a dataset and a column name containing text data, NLP Profiler will return either high-level insights or low-level/granular statistical information about the text in that column.

Other

241 stars 37 forks source link

Couple of changes: end-to-end-flow and requirements-dev.txt file #54

Closed neomatrix369 closed 3 years ago

neomatrix369 commented 3 years ago

Goal or purpose of the PR

Changes made to make sure the end-to-end flow is not ignore when [skip ci] is not used. Also include the right version of black for nbqa to work from the CLI for developers.

Actioned this on the back of the discussion on PR #53 - thanks @MarcoGorelli

Changes implemented in the PR

end-to-end-flow.yml amended by simplifying the if directive
requirements-dev.txt amended to include the right version of black

codecov[bot] commented 3 years ago

Codecov Report

Merging #54 (e01fb9b) into master (796e108) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          380       380           
  Branches        54        54           
=========================================
  Hits           380       380

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 796e108...e01fb9b. Read the comment docs.

neomatrix369 commented 3 years ago

@MarcoGorelli First commit after applying PR #53

$ gc -m "GitHub action: simplifying the if: directive in the end-to-end-flow.yml github action workflow logic to skip build with the skip ci in a commit message"
[INFO] Initializing environment for https://www.github.com/nbQA-dev/nbQA.
[INFO] Initializing environment for https://www.github.com/nbQA-dev/nbQA:black==20.8b1.
[INFO] Installing environment for https://www.github.com/nbQA-dev/nbQA.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
nbqa-black...........................................(no files to check)Skipped

LGTM!

MarcoGorelli commented 3 years ago

Cool! Makes sense that nbqa-black was skipped as none of the files you modified here were Jupyter Notebooks

neomatrix369 commented 3 years ago

Cool! Makes sense that nbqa-black was skipped as none of the files you modified here were Jupyter Notebooks

Yes agree. Loving it although I can go crazy adding more config but notebooks are not the core of the project yet. When it grows with more notebooks I wouldgo a bit more crazy with config.