neomatrix369 / nlp_profiler

A simple NLP library allows profiling datasets with one or more text columns. When given a dataset and a column name containing text data, NLP Profiler will return either high-level insights or low-level/granular statistical information about the text in that column.
Other
243 stars 37 forks source link

Granular features: corrected the name of the new feature column to noun phrase #64

Closed neomatrix369 closed 3 years ago

neomatrix369 commented 3 years ago

To be able to merge a pull request, there are a few checks:

Checklist

Please check the options that you have completed and strike-out the options that do not apply via this pull request:

Goal or purpose of the PR

Correct the misspelt term "noun phrase" or "noun phrases" across the codebase

Changes implemented in the PR

codecov[bot] commented 3 years ago

Codecov Report

Merging #64 (a9d1e1a) into master (6eabd0e) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head a9d1e1a differs from pull request most recent head 9d5568f. Consider uploading reports for the commit 9d5568f to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##            master       #64   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          498       498           
  Branches        74        74           
=========================================
  Hits           498       498           
Impacted Files Coverage Δ
nlp_profiler/constants.py 100.00% <100.00%> (ø)
nlp_profiler/granular_features/__init__.py 100.00% <100.00%> (ø)
...lp_profiler/granular_features/noun_phrase_count.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6eabd0e...9d5568f. Read the comment docs.

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.70%.

Quality metrics Before After Change
Complexity 0.24 ⭐ 0.00 ⭐ -0.24 👍
Method Length 48.27 ⭐ 111.67 🙂 63.40 👎
Working memory 2.92 ⭐ 2.24 ⭐ -0.68 👍
Quality 83.64% 79.94% -3.70% 👎
Other metrics Before After Change
Lines 199 135 -64
Changed files Quality Before Quality After Quality Change
nlp_profiler/constants.py 80.17% ⭐ 80.17% ⭐ 0.00%
nlp_profiler/granular_features/init.py 76.23% ⭐ 76.23% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!