Closed eedeleon closed 2 years ago
❌ Merging this PR will decrease code quality in the affected files by 0.33%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 0.97 ⭐ | 0.76 ⭐ | -0.21 👍 |
Method Length | 22.73 ⭐ | 23.50 ⭐ | 0.77 👎 |
Working memory | 5.18 ⭐ | 5.28 ⭐ | 0.10 👎 |
Quality | 90.49% ⭐ | 90.16% ⭐ | -0.33% 👎 |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 77 | 72 | -5 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
nlp_profiler/generate_features/parallelisation_methods/init.py | 90.64% ⭐ | 89.43% ⭐ | -1.21% 👎 |
nlp_profiler/high_level_features/grammar_quality_check.py | 90.34% ⭐ | 91.53% ⭐ | 1.19% 👍 |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
nlp_profiler/generate_features/parallelisation_methods/init.py | using_swifter | 0 ⭐ | 29 ⭐ | 10 😞 | 79.91% ⭐ | Extract out complex expressions |
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
To be able to merge a pull request, there are a few checks:
Checklist
Please check the options that you have completed and strike-out the options that do not apply via this pull request:
notebooks
folder, read the Notebooks docs)CHANGELOG.md
has been updated (please follow the existing format)Goal or purpose of the PR
Changes implemented in the PR