search

neomatrixcode / Faker.jl

generator of fake data for julia
https://faker.vercel.app/
MIT License
52 stars 11 forks source link

Remove erroneous type assert on `Random.seed!` #22

Closed vtjnash closed 3 years ago

vtjnash commented 3 years ago

If the intent was a stable sequence, then StableRNG.jl must be used and passed explicitly. Otherwise, we can just remove the erroneous function calls.

Refs https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_date/2021-06/03/Faker.1.7.0-DEV-9f32653992.log

codecov[bot] commented 3 years ago

Codecov Report

Merging #22 (a3d61a4) into master (f367e13) will increase coverage by 0.32%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   96.06%   96.39%   +0.32%     
==========================================
  Files          14       14              
  Lines         305      305              
==========================================
+ Hits          293      294       +1     
+ Misses         12       11       -1
Impacted Files Coverage Δ
src/base.jl 88.88% <100.00%> (ø)
src/phone_number.jl 100.00% <0.00%> (+16.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f367e13...a3d61a4. Read the comment docs.

neomatrixcode commented 3 years ago

Excellent, thank you very much for your contribution