neomerx / json-api

Framework agnostic JSON API (jsonapi.org) implementation
Apache License 2.0
742 stars 66 forks source link

Is v3 produciton ready? #222

Closed PabloKowalczyk closed 5 years ago

PabloKowalczyk commented 5 years ago

Hello, yesterday you published version 3.0.0 (BTW performance increase looks very good), but this release is marked as "Pre-release" on GitHub, but for composer (packagist) it is stable release. Also version number v3.0.0 looks like stable. It this version ready for production use or not?

neomerx commented 5 years ago

Long Answer V3 Passes all JSON API encoding tests that pass V2 and has 100% test coverage. So it looks at least as good as V2. Scrutinizer also likes the new code. So why it's pre-released? There are two reasons

Short Answer No, not yet. It's planned to be released in early February. I would appreciate if you try the pre-release version and provide some positive/negative/mixed feedback.

PabloKowalczyk commented 5 years ago

Now i get it. IMHO You should release v3.0.0-rc.1 first, collect feedback and/or fix bugs and then release stable v3.0.0.

I would appreciate if you try the pre-release version and provide some positive/negative/mixed feedback.

I will.

Thanks.

neomerx commented 5 years ago

renamed to v3.0.0-rc.1

PabloKowalczyk commented 5 years ago

Now everything is clear for me.

neomerx commented 5 years ago

released v3.0.0

PabloKowalczyk commented 5 years ago

Nice one :tada: Thanks!