Convert include paths to array before checks

neomerx / json-api

Framework agnostic JSON API (jsonapi.org) implementation

Apache License 2.0

743 stars 66 forks source link

Convert include paths to array before checks #239

Closed shadowhand closed 5 years ago

shadowhand commented 5 years ago

Fixes #238

neomerx commented 5 years ago

The changes look good. I can see it has to be an array. The only change I would do is formatting (align '=' and '=>'), add php doc block for the test and move the test to \Neomerx\Tests\JsonApi\Encoder\EncodeIncludedObjectsTest.

shadowhand commented 5 years ago

@neomerx updated.

neomerx commented 5 years ago

Thanks. Waiting for tests.

neomerx commented 5 years ago

I'm closing it because it was actually merged but GitHub does not understand that.

neomerx commented 5 years ago

Released in v3.0.5

shadowhand commented 5 years ago

@neomerx thanks!