neomerx / json-api

Framework agnostic JSON API (jsonapi.org) implementation
Apache License 2.0
743 stars 66 forks source link

Add method to integrate BaseQueryParser with Encoder #244

Closed efinder2 closed 4 years ago

efinder2 commented 4 years ago

I suggest to add this method to simplify the usage with the Encoder::withIncludedPaths. If this change is accepted I'll update the wiki accordingly

efinder2 commented 4 years ago

I don't know how to fix the unused variable $parsed. Any ideas?

neomerx commented 4 years ago
        foreach ($aIncludes as $path => $parsed) {
            \assert($parsed !== null);

            yield $path;
        }
neomerx commented 4 years ago

I'm OK with the idea of adding a new method. Please push to issue243 branch as a single commit with comment 'Close #243'